Skip to content

Conversation

@barakugav
Copy link

@barakugav barakugav commented Feb 26, 2025

Summary

Remove an unnecessary field in optional.
Before this PR, optional<uint64 *> was 24 bytes, after this PR its 16.

cc @JacobSzwejbka

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8720

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 5d2a1a2 with merge base 65432b1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@dbort
Copy link
Contributor

dbort commented Mar 1, 2025

Great catch! Thank you for finding and fixing this.

@dbort dbort removed their request for review March 1, 2025 02:01
@dbort dbort added the module: runtime Issues related to the core runtime and code under runtime/ label Mar 1, 2025
@barakugav barakugav closed this Jun 21, 2025
@barakugav barakugav deleted the optional branch June 21, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: runtime Issues related to the core runtime and code under runtime/ topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants