training module takes .ptd #8739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobSzwejbka
requested review from
dbort,
kirklandsign,
larryliu0820 and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8739
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9e8512d with merge base afcec1d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69547105 |
JacobSzwejbka
force-pushed
the
export-D69547105
branch
from
f0baf1d to
1df6cc8
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 26, 2025
Summary: Allow TrainingModule to take in a .ptd. Also realized I was only caching the gradient tensors not the params so went ahead and fixed that. Updated the export script to generate training modules with separated weights. Fixed a bug in tensor parsing for external mutable tensors. Differential Revision: D69547105
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69547105 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 26, 2025
Summary: Allow TrainingModule to take in a .ptd. Also realized I was only caching the gradient tensors not the params so went ahead and fixed that. Updated the export script to generate training modules with separated weights. Fixed a bug in tensor parsing for external mutable tensors. Differential Revision: D69547105
JacobSzwejbka
force-pushed
the
export-D69547105
branch
from
1df6cc8 to
879e93f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69547105 |
JacobSzwejbka
added
module: training
lucylq
approved these changes
Feb 26, 2025
Summary: Allow TrainingModule to take in a .ptd. Also realized I was only caching the gradient tensors not the params so went ahead and fixed that. Updated the export script to generate training modules with separated weights. Fixed a bug in tensor parsing for external mutable tensors. Reviewed By: lucylq, georgehong Differential Revision: D69547105
JacobSzwejbka
force-pushed
the
export-D69547105
branch
from
879e93f to
9e8512d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69547105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow TrainingModule to take in a .ptd. Also realized I was only caching the gradient tensors not the params so went ahead and fixed that.
Updated the export script to generate training modules with separated weights.
Fixed a bug in tensor parsing for external mutable tensors.
Differential Revision: D69547105