move import of VK 4-bit source quantizer into function #8744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8744
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a76485f with merge base 1caa0a1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70268708 |
nathanaelsee
added
release notes: examples
SS-JIA
approved these changes
Feb 26, 2025
Summary: Since this import is at the global scope of the module, this import only works if llama/source_transformation module is being used in libraries where the vulkan dependency is already included. In some cases this dep can fail to be linked causing export script failures. Moving the import to where it's actually needed. Reviewed By: derekxu, SS-JIA Differential Revision: D70268708
nathanaelsee
force-pushed
the
export-D70268708
branch
from
8a4dde9 to
a76485f
Compare
jackzhxng
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since this import is at the global scope of the module, this import only works if llama/source_transformation module is being used in libraries where the vulkan dependency is already included.
In some cases this dep can fail to be linked causing export script failures.
Moving the import to where it's actually needed.
Differential Revision: D70268708
cc @mergennachin @cccclai @helunwencser @jackzhxng