Skip to content

[Android] Rename build script #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[Android] Rename build script #8747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
export ARTIFACTS_DIR_NAME=artifacts-to-be-uploaded

# Build LLM Demo for Android
bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
bash build/build_android_library.sh ${ARTIFACTS_DIR_NAME}

# Running Android emulator directly on the runner and not using Docker
run-emulator:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ jobs:
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh

export ANDROID_ABIS="arm64-v8a"
PYTHON_EXECUTABLE=python EXECUTORCH_BUILD_QNN=ON QNN_SDK_ROOT=/tmp/qnn/2.28.0.241029 bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
PYTHON_EXECUTABLE=python EXECUTORCH_BUILD_QNN=ON QNN_SDK_ROOT=/tmp/qnn/2.28.0.241029 bash build/build_android_library.sh ${ARTIFACTS_DIR_NAME}

# Let's see how expensive this job is, we might want to tone it down by running it periodically
benchmark-on-device:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/android-release-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
export ARTIFACTS_DIR_NAME=artifacts-to-be-uploaded

# Build LLM Demo for Android
bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
bash build/build_android_library.sh ${ARTIFACTS_DIR_NAME}

shasum -a 256 "${ARTIFACTS_DIR_NAME}/llm_demo/executorch.aar"

Expand Down
0 build/build_android_llm_demo.sh → build/build_android_library.sh
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/demo-apps/android/LlamaDemo/docs/delegates/mediatek_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ The Mediatek runner (`examples/mediatek/executor_runner/mtk_llama_runner.cpp`) c

Next we need to build and compile the MediaTek backend and MediaTek Llama runner. By setting `NEURON_BUFFER_ALLOCATOR_LIB`, the script will build the MediaTek backend.
```
sh build/build_android_llm_demo.sh
sh build/build_android_library.sh
```

**Output**: This will generate an .aar file that is already imported into the expected directory for the Android app. It will live in `examples/demo-apps/android/Llamademo/app/libs`.
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-apps/android/LlamaDemo/setup-with-qnn.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if [ -z "$QNN_SDK_ROOT" ]; then
fi

BASEDIR=$(dirname "$0")
source "$BASEDIR"/../../../../build/build_android_llm_demo.sh
source "$BASEDIR"/../../../../build/build_android_library.sh

BUILD_AAR_DIR="$(mktemp -d)"
export BUILD_AAR_DIR
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-apps/android/LlamaDemo/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
set -eu

BASEDIR=$(dirname "$0")
source "$BASEDIR"/../../../../build/build_android_llm_demo.sh
source "$BASEDIR"/../../../../build/build_android_library.sh

BUILD_AAR_DIR="$(mktemp -d)"
export BUILD_AAR_DIR
Expand Down
2 changes: 1 addition & 1 deletion extension/android_test/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ BUILD_AAR_DIR="$(mktemp -d)"
export BUILD_AAR_DIR

BASEDIR=$(dirname "$0")
source "$BASEDIR"/../../build/build_android_llm_demo.sh
source "$BASEDIR"/../../build/build_android_library.sh

build_native_library() {
ANDROID_ABI="$1"
Expand Down
2 changes: 1 addition & 1 deletion extension/benchmark/android/benchmark/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Minibench is usedful for giving reference performance data when developers integ
You will need executorch AAR for Java and JNI dependencies.
```
export ANDROID_NDK=<path_to_android_ndk>
sh build/build_android_llm_demo.sh
sh build/build_android_library.sh
```
and copy the AAR to `app/libs`.
```
Expand Down
Loading