Skip to content

portable arg{max,min}: optimize update check #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

portable arg{max,min}: optimize update check #8755

wants to merge 3 commits into from

Conversation

@swolchok
Copy link
Contributor

We don't need a second isnan; see code comment. (This is a small optimization.)

@swolchok
Update
c9bd251 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8755

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
swolchok added a commit that referenced this pull request Feb 27, 2025
@swolchok
portable arg{max,min}: optimize update check
c173fde 
We don't need a second isnan; see code comment. (This is a small optimization.)

ghstack-source-id: 04c7bc5
ghstack-comment-id: 2686527528
Pull Request resolved: #8755
@swolchok
Update
da58a57 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 27, 2025
@swolchok
portable arg{max,min}: optimize update check
4325391 
We don't need a second isnan; see code comment. (This is a small optimization.)

ghstack-source-id: ac2afd2
ghstack-comment-id: 2686527528
Pull Request resolved: #8755
@swolchok
Update
85af042 
[ghstack-poisoned]
This was referenced Mar 1, 2025
Closed
Closed
Closed
@swolchok
Copy link
Contributor Author

swolchok commented Mar 1, 2025

messed up my stack, resubmitting

@swolchok swolchok closed this Mar 1, 2025
kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@swolchok
portable arg{max,min}: optimize update check
001175f 
We don't need a second isnan; see code comment. (This is a small optimization.)

ghstack-source-id: 1e53ab6
ghstack-comment-id: 2686527528
Pull Request resolved: pytorch/executorch#8755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swolchok @facebook-github-bot