[ET-VK][ez] Log GLSL file path on compile error #9050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Make it much easier to debug GLSL compile errors by logging the path of the GLSL file when it fails to compile. This makes it easy to quickly open up the generated GLSL and see what the compiler is complaining about. Differential Revision: [D70795732](https://our.internmc.facebook.com/intern/diff/D70795732/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 7, 2025
## Context Make it much easier to debug GLSL compile errors by logging the path of the GLSL file when it fails to compile. This makes it easy to quickly open up the generated GLSL and see what the compiler is complaining about. Differential Revision: [D70795732](https://our.internmc.facebook.com/intern/diff/D70795732/) ghstack-source-id: 270409395 Pull Request resolved: #9050
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9050
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a9fa164 with merge base e673f7c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70795732 |
nathanaelsee
approved these changes
Mar 7, 2025
facebook-github-bot
merged commit b85d165
into
gh/SS-JIA/192/base
50 of 54 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Mar 8, 2025
## Context Make it much easier to debug GLSL compile errors by logging the path of the GLSL file when it fails to compile. This makes it easy to quickly open up the generated GLSL and see what the compiler is complaining about. Differential Revision: [D70795732](https://our.internmc.facebook.com/intern/diff/D70795732/) ghstack-source-id: 270409395 Pull Request resolved: #9050 Co-authored-by: Stephen Jia <[email protected]>
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Make it much easier to debug GLSL compile errors by logging the path of the GLSL file when it fails to compile.
This makes it easy to quickly open up the generated GLSL and see what the compiler is complaining about.
Differential Revision: D70795732