- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
mkdir when destination directory doesn't exist #9055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Fixes #8980 Make sure we mkdir if destination directory doesn't exist. I have no idea why it doesn't work before [ghstack-poisoned]
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9055
 Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit 738c9f0 with merge base 6099020 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
Fixes #8980 Make sure we mkdir if destination directory doesn't exist. I have no idea why it doesn't work before cc lucylq [ghstack-poisoned]
              
                    jackzhxng
  
              
              approved these changes
              
                  
                    Mar 7, 2025 
                  
              
              
            
            
    
  larryliu0820 
      added a commit
      that referenced
      this pull request
    
      Mar 7, 2025 
    
    
      
  
    
      
    
  
Fixes #8980 Make sure we mkdir if destination directory doesn't exist. I have no idea why it doesn't work before ghstack-source-id: 745e02d Pull Request resolved: #9055 Co-authored-by: Mengwei Liu <[email protected]>
  This was referenced Mar 17, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    CLA Signed
  This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. 
  
    module: build/install
  Issues related to the cmake and buck2 builds, and to installing ExecuTorch 
  
    release notes: build
  Changes related to build, including dependency upgrades, build flags, optimizations, etc. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Stack from ghstack (oldest at bottom):
Fixes #8980
Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before
cc @lucylq