Replace {map_,}reduce_over_dim_list with {Map,}ReduceOverDimListPlan in kernels/portable #9110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9110
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 514f907 with merge base f680c44 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 10, 2025
facebook-github-bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Mar 11, 2025
JacobSzwejbka
approved these changes
Mar 11, 2025
Contributor
JacobSzwejbka
left a comment
JacobSzwejbka
left a comment
There was a problem hiding this comment.
Replacements look fine, Im assuming the OP tests will catch anything I didnt see.
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
…in kernels/portable Plan-then-execute for reductions should avoid repeating prepratory work. ghstack-source-id: f29f001 ghstack-comment-id: 2712063770 Pull Request resolved: pytorch/executorch#9110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan-then-execute for reductions should avoid repeating prepratory work.