- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
Refactor serialize.py #9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Refactor serialize.py #9124
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/) [ghstack-poisoned]
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9124
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 9de6320 with merge base 94ec549 ( NEW FAILURES - The following jobs have failed:
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
    
  lucylq 
      added a commit
      that referenced
      this pull request
    
      Mar 11, 2025 
    
    
      
  
    
      
    
  
Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/) ghstack-source-id: 270932484 Pull Request resolved: #9124
| This pull request was exported from Phabricator. Differential Revision: D70752429 | 
              
                    JacobSzwejbka
  
              
              approved these changes
              
                  
                    Mar 24, 2025 
                  
              
              
            
            
Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/) [ghstack-poisoned]
    
  lucylq 
      added a commit
      that referenced
      this pull request
    
      Mar 25, 2025 
    
    
      
  
    
      
    
  
Pull Request resolved: #9124 Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data ghstack-source-id: 273798696 Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)
| This pull request was exported from Phabricator. Differential Revision: D70752429 | 
87d0eb9
      into
      
  
    gh/lucylq/58/base
  
    
        78 of 83 checks passed
      
      
      
     Closed
  
    
  lucylq 
      added a commit
      that referenced
      this pull request
    
      Mar 25, 2025 
    
    
      
  
    
      
    
  
Pull Request resolved: #9124 Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data ghstack-source-id: 273798696 Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)
      
     Merged
  
    
  lucylq 
      added a commit
      that referenced
      this pull request
    
      Mar 25, 2025 
    
    
      
  
    
      
    
  
Pull Request resolved: #9124 Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data ghstack-source-id: 273798696 Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/) ### Summary [PLEASE REMOVE] See [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests) for ExecuTorch PR guidelines. [PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line. [PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label. For a list of available release notes labels, check out [CONTRIBUTING.md's Pull Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests). ### Test plan [PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    CLA Signed
  This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. 
  
    fb-exported
  
    topic: not user facing
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Stack from ghstack (oldest at bottom):
Refactor
_extract_tensorsout of serialize.py, simplify before serializing named_dataDifferential Revision: D70752429