Skip to content

Bump Android SDK version in docker image #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump Android SDK version in docker image #9156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c50a6ca
Bump Android SDK version in docker image
kirklandsign Mar 11, 2025
d92a0dd
Update _android.yml
kirklandsign Mar 11, 2025
370d1c5
Update build.gradle.kts
kirklandsign Mar 11, 2025
f72eca6
Update build.gradle.kts
kirklandsign Mar 11, 2025
4352f79
Update build.gradle.kts
kirklandsign Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/docker/common/install_android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ install_sdk() {
rm -rf "${SDK_INSTALLATION_DIR}" && mkdir -p "${SDK_INSTALLATION_DIR}"

# These are the tools needed to build Android apps
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "platforms;android-34"
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "build-tools;33.0.1"
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "platforms;android-35"
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "build-tools;34.0.0"
# And some more tools for future emulator tests
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "platform-tools"
yes | /opt/cmdline-tools/bin/sdkmanager --sdk_root="${SDK_INSTALLATION_DIR}" --install "tools"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
runs-on: linux.24xl.spr-metal
env:
ANDROID_NDK_VERSION: r27b
API_LEVEL: 34
API_LEVEL: 35
steps:
- name: Setup SSH (Click me for login details)
uses: pytorch/test-infra/.github/actions/setup-ssh@main
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-apps/android/ExecuTorchDemo/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ plugins {

android {
namespace = "com.example.executorchdemo"
compileSdk = 34
compileSdk = 35

defaultConfig {
applicationId = "com.example.executorchdemo"
Expand Down
2 changes: 1 addition & 1 deletion examples/demo-apps/android/LlamaDemo/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ plugins {

android {
namespace = "com.example.executorchllamademo"
compileSdk = 34
compileSdk = 35

defaultConfig {
applicationId = "com.example.executorchllamademo"
Expand Down
2 changes: 1 addition & 1 deletion extension/benchmark/android/benchmark/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins { id("com.android.application") }

android {
namespace = "org.pytorch.minibench"
compileSdk = 34
compileSdk = 35

defaultConfig {
applicationId = "org.pytorch.minibench"
Expand Down
Loading