[ET-VK] Allow memory tagging pass to handle nodes with list of tensor args #9173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… args ## Context Currently, the memory metadata tagging pass cannot properly insert memory type transitions for operators that accept a list of tensors as an input argument. This diff addresses the gap by implementing the case where a graph node's argument is a list of nodes instead of just a single node. Differential Revision: [D71005186](https://our.internmc.facebook.com/intern/diff/D71005186/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9173
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ed00538 with merge base 9dcee22 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
added a commit
that referenced
this pull request
Mar 11, 2025
… args ## Context Currently, the memory metadata tagging pass cannot properly insert memory type transitions for operators that accept a list of tensors as an input argument. This diff addresses the gap by implementing the case where a graph node's argument is a list of nodes instead of just a single node. Differential Revision: [D71005186](https://our.internmc.facebook.com/intern/diff/D71005186/) ghstack-source-id: 271146751 Pull Request resolved: #9173
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71005186 |
trivedivivek
approved these changes
Mar 12, 2025
facebook-github-bot
merged commit 95da401
into
gh/SS-JIA/196/base
50 of 54 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Mar 12, 2025
… args (#9203) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9173 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/orig @diff-train-skip-merge Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Currently, the memory metadata tagging pass cannot properly insert memory type transitions for operators that accept a list of tensors as an input argument.
This diff addresses the gap by implementing the case where a graph node's argument is a list of nodes instead of just a single node.
Differential Revision: D71005186