Skip to content

Add tests on graviton instances #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Add tests on graviton instances #9207

merged 1 commit into from
Mar 13, 2025

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Mar 12, 2025 •
edited
Loading

In the next follow-up PR, I will trim macos jobs

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9207

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@mergennachin mergennachin changed the title test on graviton instances Add tests on graviton instances Mar 12, 2025
@mergennachin mergennachin force-pushed the test_on_graviton_instances branch from fe1afac to 97f01a2 Compare March 12, 2025 22:50
@mergennachin mergennachin force-pushed the test_on_graviton_instances branch 2 times, most recently from 377b587 to 7a812c3 Compare March 13, 2025 14:12
@mergennachin mergennachin force-pushed the test_on_graviton_instances branch from 7a812c3 to 8e2cc6e Compare March 13, 2025 14:41
@mergennachin mergennachin requested a review from malfet March 13, 2025 14:44
@mergennachin mergennachin mentioned this pull request Mar 13, 2025
Merged
@mergennachin mergennachin requested a review from SS-JIA March 13, 2025 16:02
swolchok
swolchok approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for this to make sense you have to think that aarch64 coverage is enough of a substitute for macos coverage. it's a reversible decision if we turn out to have mac-only problems, so sure why not.

@swolchok
Copy link
Contributor

(also your tests are timing out, probably want to fix that)

@mergennachin mergennachin force-pushed the test_on_graviton_instances branch from 8e2cc6e to e939f70 Compare March 13, 2025 18:10
@mergennachin mergennachin force-pushed the test_on_graviton_instances branch from e939f70 to 2ac61ef Compare March 13, 2025 18:12
@mergennachin mergennachin merged commit 23a6d11 into main Mar 13, 2025
128 of 131 checks passed
@mergennachin mergennachin deleted the test_on_graviton_instances branch March 13, 2025 18:14
mergennachin added a commit that referenced this pull request Mar 13, 2025
@mergennachin
Reduce macOS CI jobs and add more Arm64 jobs. (#9228)
718aa6f 
Depends on #9227 and
#9207

Here's the net result after a sequence of PRs:

- Reduce trunk test-model-macos jobs (from 38 down to 15)
- Add arm64 trunk test-model jobs (from 0 up to 31)
- Add arm64 pull test-model-jobs jobs (+4)
@mergennachin mergennachin mentioned this pull request May 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swolchok swolchok swolchok approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@guangy10 guangy10 Awaiting requested review from guangy10

@malfet malfet Awaiting requested review from malfet

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mergennachin @swolchok @facebook-github-bot