Skip to content

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Mar 13, 2025

Issue: pytorch/test-infra#6294
Remove benchmark v2 schema logics, still keep the way to store v3 with v3 folder, since we might have higher version of schema in the future

next step is introduce the failure handling for benchmark record

@yangw-dev yangw-dev requested a review from huydhn March 13, 2025 19:14
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9238

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 889c246 with merge base 9b2cb87 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
@yangw-dev yangw-dev marked this pull request as ready for review March 13, 2025 19:23
@yangw-dev yangw-dev requested a review from ZainRizvi March 13, 2025 19:38
@yangw-dev yangw-dev temporarily deployed to upload-benchmark-results March 13, 2025 20:13 — with GitHub Actions Inactive
@yangw-dev yangw-dev temporarily deployed to upload-benchmark-results March 13, 2025 21:45 — with GitHub Actions Inactive
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yangw-dev yangw-dev merged commit a131826 into main Mar 13, 2025
70 of 71 checks passed
@yangw-dev yangw-dev deleted the deprecateV2 branch March 13, 2025 22:26
@yangw-dev yangw-dev changed the title [Benchmark]Deprecate v2 [Benchmark][BE]Deprecate v2 May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants