sync #9256
Merged
sync #9256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing #9227, It wasn't running efficient_sam, llama etc. Because I had to define all variables in the include statement. Since build-tool and runner are singletons, I just hard code it. Test Plan: Make sure trunk jobs have softmax, efficient_sam etc.
Fixing #9227 matrix.timeout is not populated. Just hard-code the value now. Also fix another cleanup DEMO_BACKEND_ID is not there anymore. Test Plan: Make sure there are 6 jobs (test-models-linux) in the pull.yml category.
### Summary * Fixes #7260 * We use flatc as part of the build step to generate some files from FlatBuffer definitions. This implies the tool runs on the host. However, we currently build flatc as part of the main build — which propagates the target CXX flags to flatc. Thus, flatc gets built targeting the target platform. To ensure flatc is built for the host, we can use include flatc as an [ExternalProject](https://cmake.org/cmake/help/latest/module/ExternalProject.html). This does not propagate the CXX flags * Some targets implicitly depended on flatc, we now make that requirement explicit * We currently spread the `FLATC_EXECUTABLE` defaulting across the project. Let's just centralize this at the root ### Test plan ```bash $ ./install_executorch.sh # Previously flatc was built against the Android target, now they target the host $ ./build/build_android_library.sh $ file /Users/jathu/executorch/cmake-out-android-arm64-v8a/third-party/flatbuffers/flatc /Users/jathu/executorch/cmake-out-android-arm64-v8a/third-party/flatbuffers/flatc: Mach-O 64-bit executable arm64 # Apple builds work as usual, but they use flatc from pip $ ./build/build_apple_frameworks.sh ``` cc @larryliu0820 @lucylq @swolchok @dbort
### Summary A series of diffs as a part of #9117. Move it from `./build` → `./scripts/build` ### Test plan CI cc @larryliu0820 @lucylq
Differential Revision: D70825994 Pull Request resolved: #9160
Unbreaks et_operator_library buck rule, which copies portable_lib source files into a new target that needs deps.
I shouldn't have deleted these, for the same reason I left thread_parallel.h behind.
Looks like I lied when I said #9227 was a no-op Adding back pull jobs for linux x86
Differential Revision: D70933388 Pull Request resolved: #9116
Issue: pytorch/test-infra#6294 Remove benchmark v2 schema logics, still keep the way to store v3 with v3 folder, since we might have higher version of schema in the future next step is introduce the failure handling for benchmark record
Differential Revision: D70645217 Pull Request resolved: #9230
Differential Revision: D71092194 Pull Request resolved: #9216
Differential Revision: D70825991 Pull Request resolved: #9244
Differential Revision: D71039057 Pull Request resolved: #8753
Reduce macos llama runners Add arm64 llama runners: distribute into pull.yml and trunk.yml jobs.
Differential Revision: D71161609 Pull Request resolved: #9249
shoumikhin
requested review from
GregoryComer,
JacobSzwejbka,
cccclai,
iseeyuan,
jackzhxng,
kimishpatel,
larryliu0820,
lucylq,
manuelcandales,
swolchok and
tarun292
as code owners
shoumikhin
requested review from
Gasoonjia,
SS-JIA,
digantdesai,
kirklandsign,
mcr229 and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9256
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
shoumikhin
added a commit
that referenced
this pull request
Mar 14, 2025
This reverts commit 8570c54.
Merged
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
mergennachin
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
shoumikhin
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
shoumikhin
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.