Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Mar 18, 2025

Enable the lintrunner to run mypy on backends/arm/test that was ignored in the initial commit of enabling mypy for backends/arm.

Mostly sad ignores but also some actual fixes.

Change-Id: Iba12558511ae938864086eb0539063a87177c0ae

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner March 18, 2025 11:55
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9357

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 530e6d1 with merge base 5a5fab7 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 18, 2025
Enable the lintrunner to run mypy on backends/arm/test that was
ignored in the initial commit of enabling mypy for backends/arm.

Mostly sad ignores but also some actual fixes.

Change-Id: Iba12558511ae938864086eb0539063a87177c0ae
@perheld perheld force-pushed the github/ph-mypy-arm-backend-test branch from 8081385 to 530e6d1 Compare March 18, 2025 11:58
@perheld
Copy link
Collaborator Author

perheld commented Mar 18, 2025

Well that exploded. I need to investigate why the result differs from our internal CI.

@digantdesai
Copy link
Contributor

wow you made linter really mad!

@byjlw
Copy link
Contributor

byjlw commented Mar 31, 2025

Well that exploded. I need to investigate why the result differs from our internal CI.

Any update on this?

@perheld
Copy link
Collaborator Author

perheld commented Apr 1, 2025

Well that exploded. I need to investigate why the result differs from our internal CI.

Any update on this?

Sadly no. Other prios, sick kids and some leave has left this very unattended from me. But I havent forgotten about it.

@perheld
Copy link
Collaborator Author

perheld commented Apr 4, 2025

I've identified why this got through and exploded. In our internal lintrunner we run with --revision HEAD^ and not --all-files so everything was green on our end. I have to run it manually with --all-files and fix all the issues and repush.

Possible with the commit adressing all issues before the commit that enables the checking of this subdirectory. 🫠

@zingo zingo marked this pull request as draft June 4, 2025 19:21
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 31, 2025
'**/third-party/**',
'scripts/check_binary_dependencies.py',
'profiler/test/test_profiler_e2e.py',
'backends/arm/test/**',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@perheld
Copy link
Collaborator Author

perheld commented Oct 22, 2025

Abandoning this, splitting up to commits per subdirectory for a managed way of getting this done. Starting with #15354

@perheld perheld closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants