-
Notifications
You must be signed in to change notification settings - Fork 697
Arm backend: Enable mypy lintrunner for backends/arm/test #9357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9357
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 530e6d1 with merge base 5a5fab7 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Enable the lintrunner to run mypy on backends/arm/test that was ignored in the initial commit of enabling mypy for backends/arm. Mostly sad ignores but also some actual fixes. Change-Id: Iba12558511ae938864086eb0539063a87177c0ae
8081385 to
530e6d1
Compare
|
Well that exploded. I need to investigate why the result differs from our internal CI. |
|
wow you made linter really mad! |
Any update on this? |
Sadly no. Other prios, sick kids and some leave has left this very unattended from me. But I havent forgotten about it. |
|
I've identified why this got through and exploded. In our internal lintrunner we run with --revision HEAD^ and not --all-files so everything was green on our end. I have to run it manually with --all-files and fix all the issues and repush. Possible with the commit adressing all issues before the commit that enables the checking of this subdirectory. 🫠 |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
| '**/third-party/**', | ||
| 'scripts/check_binary_dependencies.py', | ||
| 'profiler/test/test_profiler_e2e.py', | ||
| 'backends/arm/test/**', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
Abandoning this, splitting up to commits per subdirectory for a managed way of getting this done. Starting with #15354 |
Enable the lintrunner to run mypy on backends/arm/test that was ignored in the initial commit of enabling mypy for backends/arm.
Mostly sad ignores but also some actual fixes.
Change-Id: Iba12558511ae938864086eb0539063a87177c0ae
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218