Unbreak BroadcastIndexesRange::operator+= when there is no broadcasting #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9374
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit a865349 with merge base 89a0bdf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 18, 2025
|
This fixes a bug introduced by #9298 |
manuelcandales
approved these changes
Mar 18, 2025
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…ng (pytorch#9374) operator+= had a loop over 0 elements in this case, resulting in the indices array being full of zeros. Added a += test to our test case that covers this.
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…ng (pytorch#9374) operator+= had a loop over 0 elements in this case, resulting in the indices array being full of zeros. Added a += test to our test case that covers this.
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
operator+= had a loop over 0 elements in this case, resulting in the indices array being full of zeros. Added a += test to our test case that covers this. ghstack-source-id: 7750533 ghstack-comment-id: 2734691445 Pull Request resolved: pytorch/executorch#9374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator+= had a loop over 0 elements in this case, resulting in the indices array being full of zeros. Added a += test to our test case that covers this.