Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Mar 20, 2025

Summary

The final diff as part of #9117. This is the big one that affects users — we finally move the core build scripts into scripts/

Test plan

CI

cc @larryliu0820 @lucylq

@jathu jathu added module: ci Issues related to continuous integration module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels Mar 20, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9434

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 20a572f with merge base 76ae537 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@jathu jathu requested a review from larryliu0820 March 20, 2025 01:03
@jathu jathu force-pushed the jathu/move-build branch from e9f4af6 to 12e2b38 Compare March 20, 2025 01:06
@jathu jathu marked this pull request as ready for review March 20, 2025 01:06
@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 02:04 — with GitHub Actions Inactive
@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 02:37 — with GitHub Actions Inactive
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is a move. I would recommend importing just to make sure it works

@jathu jathu force-pushed the jathu/move-build branch from 12e2b38 to c8a8124 Compare March 20, 2025 15:22
@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 16:09 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 16:55 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jathu jathu force-pushed the jathu/move-build branch from c8a8124 to 71a85d9 Compare March 20, 2025 17:27
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 18:15 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 19:23 — with GitHub Actions Inactive
@jathu jathu temporarily deployed to upload-benchmark-results March 20, 2025 20:10 — with GitHub Actions Inactive
@jathu jathu force-pushed the jathu/move-build branch from 3def090 to 20a572f Compare March 23, 2025 04:11
@facebook-github-bot
Copy link
Contributor

@jathu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jathu jathu temporarily deployed to upload-benchmark-results March 23, 2025 04:59 — with GitHub Actions Inactive
@jathu jathu temporarily deployed to upload-benchmark-results March 23, 2025 05:48 — with GitHub Actions Inactive
@jathu jathu merged commit 9dce492 into main Mar 24, 2025
188 of 192 checks passed
@jathu jathu deleted the jathu/move-build branch March 24, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch module: ci Issues related to continuous integration release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants