[ExecuTorch][XNNPACK] validate quant params before lowering #9436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #9299 there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable ghstack-source-id: 272845697 Differential Revision: [D70775365](https://our.internmc.facebook.com/intern/diff/D70775365/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9436
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 3e59c72 with merge base 445ff34 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Mar 20, 2025
digantdesai
reviewed
Mar 21, 2025
|
|
||
|
|
||
| class OpStaticQDQNode(NodeVisitor): | ||
| def check_scales_zeropoints(self, node) -> None: |
digantdesai
reviewed
Mar 21, 2025
| float("nan"), | ||
| float("inf"), | ||
| -float("inf"), | ||
| 1.0000002153053333e-39, |
There was a problem hiding this comment.
I remember there were some additional scale restrictions for doing int requant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9299 by @mcr229
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/mcr229/12/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/12/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/mcr229/12/orig
@diff-train-skip-merge