Skip to content

Make nightly versions consistent #9453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Make nightly versions consistent #9453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4afd911
Make nightly versions consistent
mergennachin Mar 20, 2025
3c352fd
Merge branch 'main' into update_nightly_2
mergennachin Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/docker/ci_commit_pins/pytorch.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
08434df1f2f88c9770e59246caa2ff9c6f613270
295f2ed4d103017f7e19a7b8263ece606cd629db
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got from https://hud.pytorch.org/pytorch/pytorch/commit/d962699548c6740bf5d0f3ccda933de3b6fca643

2 changes: 1 addition & 1 deletion examples/models/llama3_2_vision/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

set +ex

NIGHTLY_VERSION="dev20250220"
NIGHTLY_VERSION="dev20250311"

# Install torchtune nightly for model definitions.
pip install --pre torchtune==0.6.0.${NIGHTLY_VERSION} --extra-index-url https://download.pytorch.org/whl/nightly/cpu --no-cache-dir
3 changes: 3 additions & 0 deletions install_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def python_is_compatible():
# NOTE: If a newly-fetched version of the executorch repo changes the value of
# NIGHTLY_VERSION, you should re-run this script to install the necessary
# package versions.
#
# NOTE: If you're changing, make the corresponding change in .ci/docker/ci_commit_pins/pytorch.txt
# by picking the hash from the same date in https://hud.pytorch.org/hud/pytorch/pytorch/nightly/
Comment on lines +70 to +72
Copy link
Contributor

@jathu jathu Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be an opportunity to force compliance.

  1. We should create ./tools/setup/pytorch_nightly_version.txt, which hosts this version
  2. In both files, we should read directly from that file
NIGHTLY_VERSION = open("${ROOT}/tools/setup/pytorch_nightly_version.txt", "r").read().strip()
NIGHTLY_VERSION=$(cat "${ROOT}/tools/setup/pytorch_nightly_version.txt")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, how do we find the mapping between git commit hash and nightly version?

NIGHTLY_VERSION = "dev20250311"


Expand Down
Loading