[ET-VK][ez] Make sure vTensor is not referencing the global context #9458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Some functions in `vTensor` accidentally referenced the global context by calling `context()`; the correct thing to do is to use the context pointer associated with the `vTensor` by using `storage_.context_` instead. Differential Revision: [D71560884](https://our.internmc.facebook.com/intern/diff/D71560884/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 20, 2025
## Context Some functions in `vTensor` accidentally referenced the global context by calling `context()`; the correct thing to do is to use the context pointer associated with the `vTensor` by using `storage_.context_` instead. Differential Revision: [D71560884](https://our.internmc.facebook.com/intern/diff/D71560884/) ghstack-source-id: 273023082 Pull Request resolved: #9458
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9458
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 1f4b46a with merge base ea43453 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71560884 |
This PR needs a
|
trivedivivek
approved these changes
Mar 20, 2025
facebook-github-bot
merged commit 246c3d8
into
gh/SS-JIA/198/base
79 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Mar 20, 2025
…9469) ## Context Some functions in `vTensor` accidentally referenced the global context by calling `context()`; the correct thing to do is to use the context pointer associated with the `vTensor` by using `storage_.context_` instead. Differential Revision: [D71560884](https://our.internmc.facebook.com/intern/diff/D71560884/) ghstack-source-id: 273023082 Pull Request resolved: #9458
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
…ytorch#9469) ## Context Some functions in `vTensor` accidentally referenced the global context by calling `context()`; the correct thing to do is to use the context pointer associated with the `vTensor` by using `storage_.context_` instead. Differential Revision: [D71560884](https://our.internmc.facebook.com/intern/diff/D71560884/) ghstack-source-id: 273023082 Pull Request resolved: pytorch#9458
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…ytorch#9469) ## Context Some functions in `vTensor` accidentally referenced the global context by calling `context()`; the correct thing to do is to use the context pointer associated with the `vTensor` by using `storage_.context_` instead. Differential Revision: [D71560884](https://our.internmc.facebook.com/intern/diff/D71560884/) ghstack-source-id: 273023082 Pull Request resolved: pytorch#9458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Some functions in
vTensoraccidentally referenced the global context by callingcontext(); the correct thing to do is to use the context pointer associated with thevTensorby usingstorage_.context_instead.Differential Revision: D71560884