Use xplat/caffe2:ovrsource_aten_Config.h for arvr build modes #9462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarun292
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9462
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c19ee0c with merge base 2c3fd71 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
tarun292
added a commit
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: #9462 For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
tarun292
force-pushed
the
export-D71506180
branch
from
0367632 to
85f22d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
tarun292
added a commit
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: #9462 For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
tarun292
force-pushed
the
export-D71506180
branch
from
85f22d0 to
cec0ce7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
tarun292
force-pushed
the
export-D71506180
branch
from
cec0ce7 to
6528cb9
Compare
tarun292
added a commit
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: #9462 For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
tarun292
added a commit
that referenced
this pull request
Mar 20, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
tarun292
force-pushed
the
export-D71506180
branch
from
6528cb9 to
65f9d3f
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
65f9d3f to
e8d5202
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
tarun292
added a commit
that referenced
this pull request
Mar 20, 2025
Summary: Pull Request resolved: #9462 For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
tarun292
force-pushed
the
export-D71506180
branch
from
e8d5202 to
a255ae3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
a255ae3 to
6bdd0ca
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
swolchok
reviewed
Mar 20, 2025
| "//xplat/caffe2:generated_aten_config_header", | ||
| "//xplat/caffe2/c10:c10_headers", | ||
| ], | ||
| ] + ["//xplat/caffe2:ovrsource_aten_Config.h" if is_arvr_mode() else "//xplat/caffe2:generated_aten_config_header",], |
Contributor
There was a problem hiding this comment.
do we also need to cover line 63 above?
Contributor
Author
There was a problem hiding this comment.
shouldn't be needed as arvr only uses xplat_exported_deps and not fbcode_exported_deps
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
6bdd0ca to
3ce0b8d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
3ce0b8d to
eaf19a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
eaf19a3 to
f39089d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
Summary: For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
facebook-github-bot
force-pushed
the
export-D71506180
branch
from
f39089d to
c19ee0c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71506180 |
swolchok
approved these changes
Mar 21, 2025
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
Differential Revision: D71506180 Pull Request resolved: pytorch#9462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For arvr modes we should use
//xplat/caffe2:ovrsource_aten_Config.hto get the ATen config headers as theovrsourcevariants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures.Differential Revision: D71506180