Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Mar 21, 2025

Summary

Context: #9481

We now create the pybinding target for inmemoryfs. Note that the build recipe is from the wheel builder:

ext_modules = [
Pybind11Extension(
"executorchcoreml",
[
"../util/json_util.cpp",
"inmemory_filesystem.cpp",
"inmemory_filesystem_py.cpp",
"inmemory_filesystem_utils.cpp",
"memory_buffer.cpp",
"memory_stream.cpp",
"reversed_memory_stream.cpp",
],
define_macros=[("VERSION_INFO", __version__)],
cxx_std=cxx_std,
extra_compile_args=["-mmacosx-version-min=10.15", "-g"],
include_dirs=[
"../../third-party/nlohmann_json/single_include",
".",
"../util",
],
),
]

Test plan

$ cmake -B cmake-out -S . -DEXECUTORCH_BUILD_PYBIND=ON -DEXECUTORCH_BUILD_COREML=ON
$ cmake --build cmake-out -j$(sysctl -n hw.ncpu) --target executorchcoreml

$ ./install_executorch.sh --pybind coreml

cc @larryliu0820 @lucylq

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9482

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 588fa40 with merge base c890809 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk topic: not user facing labels Mar 21, 2025
@jathu jathu marked this pull request as ready for review March 21, 2025 01:02
@jathu jathu force-pushed the jathu/inmemoryfs-binding branch 2 times, most recently from 8401ea6 to 3d18509 Compare March 21, 2025 03:51
@jathu jathu force-pushed the jathu/split-coreml branch from 1f3966d to 05b129a Compare March 21, 2025 14:52
@jathu jathu force-pushed the jathu/inmemoryfs-binding branch 3 times, most recently from eaddcd2 to dc338bd Compare March 21, 2025 14:57
@jathu jathu force-pushed the jathu/split-coreml branch 8 times, most recently from e6419ac to 296af8f Compare March 22, 2025 00:09
@jathu jathu force-pushed the jathu/split-coreml branch 13 times, most recently from f96e713 to 6c82a26 Compare March 24, 2025 22:45
Base automatically changed from jathu/split-coreml to main March 24, 2025 23:56
@jathu jathu force-pushed the jathu/inmemoryfs-binding branch 2 times, most recently from 5bc0bdc to 7e51d3a Compare March 25, 2025 00:11
@jathu jathu force-pushed the jathu/inmemoryfs-binding branch 2 times, most recently from 1287a85 to 2f299ac Compare March 25, 2025 01:52
@jathu jathu force-pushed the jathu/inmemoryfs-binding branch from 2f299ac to 4c09e91 Compare March 25, 2025 15:18
@jathu jathu merged commit 3b2a8ca into main Mar 25, 2025
168 of 172 checks passed
@jathu jathu deleted the jathu/inmemoryfs-binding branch March 25, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants