Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Mar 21, 2025

  • Rename bitwise and logical tests with full aten op name
  • Refactor the tests with test_pipeline and new Xfail decorator
  • Fix the naming error in test_any

Change-Id: I9b281f0a224280dca7609321594d0ed2f4fdb63c

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 21, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9499

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Pending

As of commit afdbf30 with merge base 69cc7fa (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@YufengShi-dudu
Copy link
Collaborator Author

Commit [02037b7] failed on test-arm-reference-delegation / linux-job:

backends/arm/test/ops/test_scalars.py::test_passes_BI[Div__float_r1_ts] 
[gw1] [ 66%] FAILED backends/arm/test/ops/test_scalars.py::test_passes_BI[Div__float_r1_ts] 

But it should be XFAIL.

Commit [19a78bf] behaves as expected:

backends/arm/test/ops/test_scalars.py::test_passes_BI[Div__float_r1_ts] 
[gw2] [ 66%] XFAIL backends/arm/test/ops/test_scalars.py::test_passes_BI[Div__float_r1_ts]

Was this failure caused by some commits between these two merges?

@Erik-Lundell
Copy link
Collaborator

The unexpected success is likely just due to randomness, I set the xfail to non-strict to deal with this here :#9644. Will rebase for you.

@zingo
Copy link
Collaborator

zingo commented Mar 31, 2025

Hi @YufengShi-dudu I think this might need a rebase the sigmoid_32bit tests you get an error on was fixed last week.

EDIT: There might still be some flakynes in that test. Sorry for the confusion.

- Rename bitwise and logical tests with full aten op name
- Refactor the tests with test_pipeline and new Xfail decorator
- Fix the naming error in test_any

Change-Id: I9b281f0a224280dca7609321594d0ed2f4fdb63c
Signed-off-by: Yufeng Shi <[email protected]>
@zingo zingo force-pushed the refactor-bitwise-logical-tests branch from d3f9578 to afdbf30 Compare March 31, 2025 12:01
@zingo
Copy link
Collaborator

zingo commented Mar 31, 2025

qnn and macos test problems are unrelated

@zingo zingo merged commit bad2fa9 into pytorch:main Mar 31, 2025
164 of 166 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
- Rename bitwise and logical tests with full aten op name
- Refactor the tests with test_pipeline and new Xfail decorator
- Fix the naming error in test_any

Signed-off-by: Yufeng Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants