Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

Summary

Initially, --compile_only will use 1 random input for CI purpose. Introducing --ci flag, so when users are using --compile_only, they won't be getting models with poor accuracy.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9536

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit b0e326c with merge base d7201ab (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2025
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/external_ci_refactor branch 2 times, most recently from f84ff4f to c53f700 Compare May 5, 2025 03:39
@winskuo-quic winskuo-quic changed the title [WIP]Qualcomm AI Engine Direct - Flags for CI Qualcomm AI Engine Direct - Flags for CI May 5, 2025
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/external_ci_refactor branch from c53f700 to b29d2ec Compare May 6, 2025 06:15
@winskuo-quic winskuo-quic reopened this May 6, 2025
@winskuo-quic winskuo-quic marked this pull request as ready for review May 6, 2025 06:16
@winskuo-quic winskuo-quic requested a review from cccclai as a code owner May 6, 2025 06:16
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai, @guangy10,
This PR is to add a new flag for external CI, so that compile_only flag can still generate a pte with good accuracy.
I also removed some unused code under QNN.
Please have a look.
Thanks


parser.add_argument(
"--ci",
help="This flag is for Continuous Integration(CI) purpose and is NOT recommended to turn on for typical use cases.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="This flag is for Continuous Integration(CI) purpose and is NOT recommended to turn on for typical use cases.",
help="This flag is for Continuous Integration(CI) purpose and is NOT recommended to turn on for typical use cases. It will use random inputs instead of real inputs.",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks for reviewing the PR!

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit f1ef702 into pytorch:main May 13, 2025
176 of 178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants