refactor _Dim into Dim #9559
Closed
refactor _Dim into Dim #9559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9559
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit f5ce284 with merge base 306b649 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
facebook-github-bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Mar 24, 2025
Summary: X-link: pytorch/executorch#9559 forward fix T218515233 Differential Revision: D71769231
digantdesai
reviewed
Mar 25, 2025
| dim_spec = dim_spec.root | ||
| fn = dim_spec.fn | ||
| elif isinstance(dim_spec, torch.export.dynamic_shapes._Dim): | ||
| elif isinstance(dim_spec, torch.export.dynamic_shapes.Dim): |
Contributor
There was a problem hiding this comment.
did this change in pytorch?
jingsh
approved these changes
Mar 25, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Summary: X-link: meta-pytorch/torchrec#2847 X-link: pytorch/pytorch#149891 forward fix T218515233 Differential Revision: D71769231
facebook-github-bot
force-pushed
the
export-D71769231
branch
from
97daf75 to
e00ab15
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 25, 2025
Summary: X-link: meta-pytorch/torchrec#2847 X-link: pytorch/executorch#9559 forward fix T218515233 Test Plan: test_export Differential Revision: D71769231
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Summary: X-link: meta-pytorch/torchrec#2847 X-link: pytorch/pytorch#149891 forward fix T218515233 Differential Revision: D71769231
facebook-github-bot
force-pushed
the
export-D71769231
branch
from
e00ab15 to
915ca72
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
facebook-github-bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Mar 25, 2025
Summary: X-link: pytorch/pytorch#149891 X-link: pytorch/executorch#9559 forward fix T218515233 Differential Revision: D71769231
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: X-link: meta-pytorch/torchrec#2847 X-link: pytorch/pytorch#149891 forward fix T218515233 Differential Revision: D71769231
facebook-github-bot
force-pushed
the
export-D71769231
branch
from
915ca72 to
f5ce284
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 26, 2025
Summary: X-link: meta-pytorch/torchrec#2847 X-link: pytorch/executorch#9559 forward fix T218515233 Test Plan: test_export Differential Revision: D71769231
facebook-github-bot
pushed a commit
to meta-pytorch/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: X-link: pytorch/pytorch#149891 X-link: pytorch/executorch#9559 forward fix T218515233 Differential Revision: D71769231
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
pianpwk
force-pushed
the
export-D71769231
branch
from
f5ce284 to
c43d5ad
Compare
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
JakeStevens
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
update-viable-strict
GitHub Actions
Inactive
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71769231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: forward fix T218515233
Differential Revision: D71769231