Create intermediate directories in ETCoreMLModelManager #9562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9562
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 62 Pending, 2 Unrelated FailuresAs of commit 34ea2dd with merge base 644b7dd ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
metascroy
added
ciflow/trunk
module: coreml
Contributor
Author
|
@cymbalrush can you have a look? |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cymbalrush
approved these changes
Mar 25, 2025
cccclai
approved these changes
Mar 25, 2025
Contributor
cccclai
left a comment
cccclai
left a comment
There was a problem hiding this comment.
Approve on behalf of @cymbalrush
metascroy
force-pushed
the
fix-coreml-fb-app
branch
from
9f1372f to
265e84a
Compare
Contributor
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETCoreML crashes in FB app. During debugging, we traced issue down to this.
cc @kimishpatel @YifanShenSZ @cymbalrush