Skip to content

Conversation

@yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Mar 28, 2025

Fix bug to upload error benchmark report: benchmakr_values:[0]
Unable to see the failure report in clickhouse, wonder if bc this

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9731

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 2b3dff0 with merge base 97bca05 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@yangw-dev yangw-dev requested a review from huydhn March 28, 2025 03:31
@yangw-dev yangw-dev marked this pull request as ready for review March 28, 2025 03:31
@yangw-dev yangw-dev requested a review from clee2000 March 28, 2025 03:31
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have made the same mistake before using a value instead of a list for benchmark_values. Let's add a check in the upload script to throw an error so that this will fail on CI instead.

@huydhn huydhn merged commit 4987f0b into main Apr 2, 2025
81 of 82 checks passed
@huydhn huydhn deleted the fixBenchBug branch April 2, 2025 08:03
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
Fix bug to upload error benchmark report: benchmakr_values:[0]
Unable to see the failure report in clickhouse, wonder if bc this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants