Add cadence.where_Scalar op #9764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9764
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d29f64f with merge base d6bc799 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 31, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
ba35880 to
bfc9f46
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 31, 2025
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
bfc9f46 to
0468e28
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 31, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
0468e28 to
3755d99
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 31, 2025
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
3755d99 to
d2d57cf
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
d2d57cf to
f35ad09
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
f35ad09 to
2b63160
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
2b63160 to
de047f0
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
de047f0 to
1b40ea0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
force-pushed
the
export-D70539497
branch
from
1b40ea0 to
331d103
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
331d103 to
63bab5d
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 1, 2025
Summary: The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
mcremon-meta
force-pushed
the
export-D70539497
branch
from
63bab5d to
cd002c4
Compare
Summary: Pull Request resolved: #9764 The op replaces the regular where op when it uses two `aten.full` ops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if the `condition` is a constant tensor. Since `aten.full` is _not_ currently constant folded, it would stay in the graph. Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D70539497
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70539497 |
mcremon-meta
force-pushed
the
export-D70539497
branch
from
cd002c4 to
d29f64f
Compare
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D70539497 Pull Request resolved: #9764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The op replaces the regular where op when it uses two
aten.fullops for the tensors. Those cases do no need broadcast (but would call it in the current state) and can sometimes be constant folded, if theconditionis a constant tensor. Sinceaten.fullis not currently constant folded, it would stay in the graph.Reviewed By: skrtskrtfb
Differential Revision: D70539497