ROCm: Migrate to native CMake HIP support#478
ROCm: Migrate to native CMake HIP support#478GZGavinZhao wants to merge 1 commit intopytorch:mainfrom
Conversation
|
Hi @GZGavinZhao! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
d4l3k
left a comment
d4l3k
left a comment
There was a problem hiding this comment.
LGTM these changes generally look fine though we don't have any rocm CI setup
Have you tested with pytorch/pytorch?
|
#488 should help with CI @GZGavinZhao can you rebase on top of that once that lands? |
|
Sounds good! Thanks for that. I've subscribed to that PR and will rebase once that's merged. |
|
@pytorchbot rebase |
|
@GZGavinZhao can you manually rebase? I don't think PT bot will work in this repo actually |
GZGavinZhao
force-pushed
the
native-cmake-hip
branch
from
02d5f7e to
4e21ba5
Compare
|
@d4l3k Rebased, sorry for the delay, was trying to test this with PyTorch on Windows but got stuck with ROCm/TheRock/issues/3283. I guess I'll test this with PyTorch on Linux only. |
3 participants
Fixes #477.
Using CMake's native HIP support is now the recommended way to use HIP, as shown in the official docs. It has much better developer ergonomics.
The only change I'm concerned about is bumping minimum CMake version from 3.18 to 3.21. I don't know if this will have any consequences for downstream users.