Skip to content

gloo: improve error message on connection closed #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Feb 7, 2026
+16 −4
Merged

gloo: improve error message on connection closed #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions gloo/transport/tcp/pair.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,17 +534,29 @@ bool Pair::read() {
}

// Unexpected error
signalException(
GLOO_ERROR_MSG("Read error ", peer_.str(), ": ", strerror(errno)));
signalException(GLOO_ERROR_MSG(
"Read error ",
peer_.str(),
": ",
strerror(errno),
". ",
"This is typically caused by a remote worker hanging or bugs in the application. ",
"Check the logs of the remote worker before reporting an error. ",
"GLHF! 🏖️"));
return false;
}
break;
}

// Transition to CLOSED on EOF
if (rv == 0) {
signalException(
GLOO_ERROR_MSG("Connection closed by peer ", peer_.str()));
signalException(GLOO_ERROR_MSG(
"Connection closed by peer ",
peer_.str(),
". ",
"This is typically caused by a remote worker crashing. ",
"Check the logs of the remote worker before reporting an error. ",
"GLHF! 🏖️"));
return false;
}

Expand Down
Loading