Limit tensor block numel to triton's requirements #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
force-pushed
the
oulgen/stack/63
branch
from
be7d80a to
9bd1e7f
Compare
meta-cla
bot
added
the
CLA Signed
jansel
requested changes
Aug 12, 2025
Comment on lines
+189
to
+192
| if name == "block_sizes" and math.prod(values) > 1048576: | ||
| raise InvalidConfig( | ||
| "Triton does not allow for tensor numel greater than 1048576" | ||
| ) |
There was a problem hiding this comment.
Not all block sizes should be included in this count, only the ones in the top level loop. We might need to tag some block sizes as coming from the grid and only count those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Limit tensor block numel to triton's requirements
Fixes #456