Skip to content

[BugFix] Use torch.zeros for argument in torch.where #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] Use torch.zeros for argument in torch.where #3239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions torchrl/modules/tensordict_module/rnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,9 +724,6 @@ def forward(self, tensordict: TensorDictBase):
tensordict_shaped.get(key, default)
for key, default in zip(self.in_keys, defaults)
)
batch, steps = value.shape[:2]
device = value.device
dtype = value.dtype
# packed sequences do not help to get the accurate last hidden values
# if splits is not None:
# value = torch.nn.utils.rnn.pack_padded_sequence(value, splits, batch_first=True)
Expand All @@ -737,8 +734,13 @@ def forward(self, tensordict: TensorDictBase):
# When using the recurrent_mode=True option, the lstm can be called from
# any intermediate state, hence zeroing should not be done.
is_init_expand = expand_as_right(is_init, hidden0)
hidden0 = torch.where(is_init_expand, 0, hidden0)
hidden1 = torch.where(is_init_expand, 0, hidden1)
zeros = torch.zeros_like(hidden0)
hidden0 = torch.where(is_init_expand, zeros, hidden0)
hidden1 = torch.where(is_init_expand, zeros, hidden1)

batch, steps = value.shape[:2]
device = value.device
dtype = value.dtype

val, hidden0, hidden1 = self._lstm(
value, batch, steps, device, dtype, hidden0, hidden1
Expand Down