Skip to content

viable strict: dedup two scripts, remove checkout of test-infra #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 9, 2024
Merged

viable strict: dedup two scripts, remove checkout of test-infra #5750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
18c1be9
tc
clee2000 Oct 7, 2024
74d3aa9
tc
clee2000 Oct 7, 2024
d33616d
tc
clee2000 Oct 7, 2024
6ef9060
tc
clee2000 Oct 7, 2024
ec9b28e
tc
clee2000 Oct 7, 2024
45dbe1c
tc
clee2000 Oct 7, 2024
524990a
tc
clee2000 Oct 7, 2024
0b0165f
tc
clee2000 Oct 7, 2024
8693cf0
tc
clee2000 Oct 7, 2024
7588550
tc
clee2000 Oct 7, 2024
07ec511
tc
clee2000 Oct 8, 2024
f81f5fd
tc
clee2000 Oct 8, 2024
24476ba
tc
clee2000 Oct 8, 2024
a8185d4
tc
clee2000 Oct 8, 2024
1f02bfd
tc
clee2000 Oct 8, 2024
de8dc9e
tc
clee2000 Oct 8, 2024
f2b6645
tc
clee2000 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/actions/update-viablestrict/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@ runs:
with:
python-version: '3.11'

- name: Checkout test-infra for the fetch_latest_green_commit scripts
uses: actions/checkout@v3
with:
repository: ${{ inputs.test-infra-repository }}
ref: ${{ inputs.test-infra-ref }}
path: test-infra

- uses: actions/checkout@v3
with:
repository: ${{ inputs.repository }}
Expand All @@ -85,8 +78,14 @@ runs:
run: |
set -ex

output=$(python ${GITHUB_WORKSPACE}/test-infra/.github/scripts/fetch_latest_green_commit.py --requires "${{ inputs.requires }}")
TEST_INFRA_PATH="${GITHUB_ACTION_PATH}/../../.."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an uneasy feeling about this. My understanding is that the runner keeps all the GHA it needs locally, and because we don't have ephemeral runner, test-infra is there because some other jobs have already fetched it. The problem here is that I'm not sure if the version of test-infra is correct, and we could end up with a stale GHA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could test this out on an ephemeral linux runner and see if test-infra is there I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run I linked as the test uses runs-on: ubuntu-20.04, I assume gha runners are as ephemeral as our linux runners? Unless maybe gha runners are more special

The version did run my the code in my branch (it errored when the argument flags were wrong)


output=$(python ${TEST_INFRA_PATH}/tools/scripts/fetch_latest_green_commit.py \
--required-checks "${{ inputs.requires }}" \
--viable-strict-branch "viable/strict" \
--main-branch "master")
echo "latest_viable_sha=$output" >> "${GITHUB_OUTPUT}"
echo $output

- name: Push SHA to viable/strict branch
if: steps.get-latest-commit.outputs.latest_viable_sha != 'None'
Expand Down
156 changes: 0 additions & 156 deletions .github/scripts/fetch_latest_green_commit.py
View file
Open in desktop

This file was deleted.

Loading
Loading