Added default-packages to setup-miniconda (#5789) #5907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default setup-miniconda installs a bunch of packages that may cause conflicts with packages the user wants to install. So add a parameter that can control the default packages. A user could set it to empty if they don't want to install anything but python. More context: I was using this library and getting failures when installing ffmpeg7:  https://github.com/pytorch/torchcodec/actions/runs/11431285586/job/31800252965?pr=272 After this change I can install ffmpeg successfully by specifying it in the default-packages list.
Without this there would be cache collisions of different default-packages. i.e. the symptom I was seeing was the cache would restore my conda environment but without the packages. I tested it here with torchcodec meta-pytorch/torchcodec#298 https://github.com/pytorch/torchcodec/actions/runs/11523232397/job/32081186451?pr=298 And it seems to be working fine. Example the cache key contains the package hashes: <img width="1193" alt="image" src="https://github.com/user-attachments/assets/f04d6ac9-ff72-4f07-b5ef-831b6d3fd09f">
|
@ahmadsharif1 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@atalman you will have to merge this PR because I do not have the authorization to run the Vercel check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #5789 and #5821 to release/2.5 branch
This is needed for torchcodec CI to succeed:
meta-pytorch/torchcodec#373