Skip to content

Add support for benchmark configs on ExecuTorch dashboard #6110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add support for benchmark configs on ExecuTorch dashboard #6110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchci/clickhouse_queries/oss_ci_benchmark_branches/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ WITH benchmarks AS (
tupleElement(o.benchmark, 'extra_info') [ 'arch' ],
tupleElement(o.runners [ 1 ], 'type')
) AS arch,
o.timestamp AS timestamp,
toStartOfDay(fromUnixTimestamp(o.timestamp)) AS event_time
FROM
benchmark.oss_ci_benchmark_v3 o
Expand Down Expand Up @@ -43,7 +44,6 @@ WITH benchmarks AS (
OR empty({excludedMetrics: Array(String) })
)
AND notEmpty(o.metric.name)
AND notEmpty(o.benchmark.dtype)
)
SELECT
DISTINCT replaceOne(head_branch, 'refs/heads/', '') AS head_branch,
Expand All @@ -66,4 +66,4 @@ WHERE
AND notEmpty(device)
ORDER BY
head_branch,
event_time DESC
timestamp DESC
1 change: 0 additions & 1 deletion torchci/clickhouse_queries/oss_ci_benchmark_llms/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ WITH benchmarks AS (
OR empty({excludedMetrics: Array(String) })
)
AND notEmpty(o.metric.name)
AND notEmpty(o.benchmark.dtype)
)
SELECT
DISTINCT workflow_id,
Expand Down
1 change: 0 additions & 1 deletion torchci/clickhouse_queries/oss_ci_benchmark_names/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ WITH benchmarks AS (
OR empty({excludedMetrics: Array(String) })
)
AND notEmpty(o.metric.name)
AND notEmpty(o.benchmark.dtype)
)
SELECT
DISTINCT benchmark,
Expand Down
20 changes: 10 additions & 10 deletions torchci/pages/benchmark/llms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,9 @@ export default function Page() {
JSON.stringify(queryParams)
)}`;

console.log(queryParams);
const { data } = useSWR(url, fetcher, {
refreshInterval: 60 * 60 * 1000, // refresh every hour
});
console.log(data);

if (data === undefined || data.length === 0) {
return <>Loading {REPO_TO_BENCHMARKS[repoName].join(", ")}...</>;
Expand All @@ -274,10 +272,10 @@ export default function Page() {
DEFAULT_DEVICE_NAME,
...(_.uniq(data.map((r: any) => `${r.device} (${r.arch})`)) as string[]),
];
const dtypeNames: string[] = [
const dtypeNames: string[] = _.compact([
DEFAULT_DTYPE_NAME,
...(_.uniq(data.map((r: any) => r.dtype)) as string[]),
];
]);
const metricNames: string[] = _.uniq(data.map((r: any) => r.metric));

return (
Expand Down Expand Up @@ -330,12 +328,14 @@ export default function Page() {
label={"Backend"}
/>
)}
<DTypePicker
dtype={dtypeName}
setDType={setDTypeName}
dtypes={dtypeNames}
label={"DType"}
/>
{dtypeNames.length > 1 && (
<DTypePicker
dtype={dtypeName}
setDType={setDTypeName}
dtypes={dtypeNames}
label={"DType"}
/>
)}
<DTypePicker
dtype={deviceName}
setDType={setDeviceName}
Expand Down
Loading