Skip to content

[RFC] add class support in bc-linter #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhewenl
Copy link

@zhewenl zhewenl commented Jul 25, 2025

as discussed with @izaitsevfb, we want to also include linter checks on classes in addition to public functions; but prior to landing this PR, we need to create some rules template for linters, where we can define what to check(or not).
Like:

pytorch:
- Files: global
- Include: functions

vLLM:
- Files: vllm/v1/attrition, vllm/v1/core
- Include, classes, functions

cc @huydhn @yangw-dev @houseroad

Copy link

vercel bot commented Jul 25, 2025

@zhewenl is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2025
@zhewenl zhewenl changed the title add class [do not commit] add class support in bc-linter Jul 25, 2025
@zhewenl zhewenl changed the title [do not commit] add class support in bc-linter [RFC] add class support in bc-linter Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants