Skip to content

[HUD] Move a bunch of code for the main hud tables around #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Aug 8, 2025

Changes:

  • Get rid of GroupFilterableHudTable by flattening it into the parent (it was sort of a wrapper component)
  • Get rid of HudTable component by flattening it into the parent
  • Create a component just for FiltersAndSettings which has the job filter search and the settings
    • Move this component so that it's in a location that still gets shown even when the HUD data is still being fetched
    • Fetches data from contexts and the router instead of the input params for all the settings in this component (not sure if this is a good idea. It's nice to not have to pass a ton of things in, but maybe there are perf issues)
  • Adds a bunch of useRouter everywhere to get params instead of passing it around as an input param (maybe this has perf issues)

Should have no visual changes other than the loading thing

Pros:

  • Got rid of some components (flattened them out) -> less confusing
  • Move a bunch of input params to be fetched in the component from providers -> don't need to to pass things around all the time
  • job filters + settings are still shown when the hud data is still loading

Cons:

  • Maybe causes worse perf? ex more rerenders? unsure

Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Aug 8, 2025 8:22pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@clee2000 clee2000 marked this pull request as ready for review August 8, 2025 19:38
@clee2000 clee2000 requested a review from a team August 8, 2025 19:38
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I loaded the preview and clicked around, but didn't spot anything wrong with HUD loading

@clee2000 clee2000 merged commit 7b148a5 into main Aug 12, 2025
5 checks passed
@clee2000 clee2000 deleted the csl/hud_refactor branch August 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants