Skip to content

[HUD] Display on hud table the autorevert decisions #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[HUD] Display on hud table the autorevert decisions #7304

wants to merge 8 commits into from
+420 −12

Conversation

jeanschmidt
Copy link
Contributor

  • Highlight hud autorevert decisions on main hud table with a different background
  • Add a banner on hover for autoreverted commits on main hud table
  • Special background for signals that are flagged to autorevert, making them easier to identify
  • Adds a banner on commit page about the autorevert and the identified signals

@pytorch-bot pytorch-bot bot added the ci-no-td label Oct 6, 2025
@vercel Vercel
Copy link

vercel bot commented Oct 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Oct 6, 2025 5:12pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@jeanschmidt
Copy link
Contributor Author

Screenshot 2025-10-06 at 18 48 30 Screenshot 2025-10-06 at 18 48 12

@jeanschmidt
[HUD] fix lint
b7cb9e2 
Signed-off-by: Jean Schmidt <[email protected]>
@jeanschmidt
Copy link
Contributor Author

jeanschmidt commented Oct 6, 2025 •
edited
Loading

FYI: test error is unrelated to the change, it is a library that changed behaviour and I am not managing this in this PR

izaitsevfb
izaitsevfb reviewed Oct 6, 2025
View reviewed changes
torchci/lib/utilization/fetchUtilization.test.ts
// assert log
expect(logSpy).toHaveBeenCalledWith(
`Warning: Error parsing JSON:SyntaxError: Expected property name or '}' in JSON at position 1 for data string '{{}dsad}'`
`Warning: Error parsing JSON:SyntaxError: Expected property name or '}' in JSON at position 1 (line 1 column 2) for data string '{{}dsad}'`
Copy link
Contributor

@izaitsevfb izaitsevfb Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tried to fix, but the message is not correct, I can remove the change

izaitsevfb
izaitsevfb reviewed Oct 6, 2025
View reviewed changes
torchci/pages/hud/[repoOwner]/[repoName]/[branch]/[[...page]].tsx
);
} else {
const job = rowData.nameToJobs.get(name);
const jobFullName = job?.name || name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this logic should be extracted into a separate method

@izaitsevfb
Copy link
Contributor

izaitsevfb commented Oct 6, 2025 •
edited
Loading

Several notes:

  1. Please address accidental changes.

  2. The job marking logic doesn't work when grouping is enabled:
    image
    image
    please extract the common logic that determines if job should be marked and reuse it for both codepaths, also check other settings, like failures monsterization.

  3. the red border is very similar to "blocks viable strict". maybe let's choose another color to avoid confusion?

    image vs image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaitsevfb izaitsevfb izaitsevfb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanschmidt @izaitsevfb