Split up Simple Staging and Legacy Staging Logic #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D79434609 |
Saiteja64
added a commit
that referenced
this pull request
Aug 6, 2025
Summary: Currently base_async_storage_writer is quite complicated and has a bunch of branching between simple_staging and legacy staging. We are looking to introduce yet another simple staging solution. So refactor as follows: Last half, we introduced stager as an argument to DCP async_save. 1. Introduce LegacyStager and move legacy staging logic intop it 2. Introduce SimpleStager and move simple staging logic into it. 3. Based on JKs in checkpoint_dist_client initialize the right stager to use. 4. Remove Staging Logic From BaseAsyncStorageWriter Differential Revision: D79434609
Saiteja64
force-pushed
the
export-D79434609
branch
from
d3262b8 to
c1469dc
Compare
Summary: Pull Request resolved: #1022 Currently base_async_storage_writer is quite complicated and has a bunch of branching between simple_staging and legacy staging. We are looking to introduce yet another simple staging solution. So refactor as follows: Last half, we introduced stager as an argument to DCP async_save. 1. Introduce LegacyStager and move legacy staging logic intop it 2. Introduce SimpleStager and move simple staging logic into it. 3. Based on JKs in checkpoint_dist_client initialize the right stager to use. 4. Remove Staging Logic From BaseAsyncStorageWriter Differential Revision: D79434609
|
This pull request was exported from Phabricator. Differential Revision: D79434609 |
Saiteja64
force-pushed
the
export-D79434609
branch
from
c1469dc to
7be41bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently base_async_storage_writer is quite complicated and has a bunch of branching between simple_staging and legacy staging. We are looking to introduce yet another simple staging solution. So refactor as follows:
Last half, we introduced stager as an argument to DCP async_save.
Differential Revision: D79434609