Skip to content

Add on_eval_epoch_end as a valid hook to TorchSnapshotSaver #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add on_eval_epoch_end as a valid hook to TorchSnapshotSaver #826

wants to merge 1 commit into from

Conversation

dorukhansergin
Copy link
Contributor

Summary:
When TorchSnapshotSaver is used with save_every_n_eval_epochs > 0 and best_checkpoint_config, this hook is invoked.

https://www.internalfb.com/code/fbsource/[a8a4a7fba9a8a93af7382fa12e669c066f41024f]/fbcode/torchtnt/framework/callbacks/base_checkpointer.py?lines=273

However, it fails due to not being considered a valid hook. This diff fixes that

Differential Revision: D57083777

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57083777

@dorukhansergin @facebook-github-bot
Add on_eval_epoch_end as a valid hook to TorchSnapshotSaver (pytorch#826
1ccdf82 
)

Summary:

When `TorchSnapshotSaver` is used with `save_every_n_eval_epochs > 0` and `best_checkpoint_config`, this hook is invoked.

https://www.internalfb.com/code/fbsource/[a8a4a7fba9a8a93af7382fa12e669c066f41024f]/fbcode/torchtnt/framework/callbacks/base_checkpointer.py?lines=273

However, it fails due to not being considered a valid hook. This diff fixes that

Differential Revision: D57083777
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57083777

@facebook-github-bot
Copy link
Contributor

Hi @dorukhansergin!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorukhansergin @facebook-github-bot