Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@kwen2501
Copy link
Contributor

Accommodate review comments of previous PR:
avoid calculating these IDs multiple times.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1150

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6ffca66 with merge base 7708646 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 15, 2024
@kwen2501 kwen2501 requested a review from lessw2020 September 15, 2024 18:37
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
Note that I had already done this in my batch decoding PR, but I updated my variable names to match yours for dst/src.
Thus, may not need to merge this but approving regardless.

@kwen2501 kwen2501 merged commit 8b45633 into main Sep 15, 2024
51 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants