Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@lessw2020
Copy link
Contributor

@lessw2020 lessw2020 commented Sep 15, 2024

This PR:

  1. enables batch decoding such that multiple prompts can be run and processed at the same time.
  2. moves the dst/src calcs for pp comms out of the decoding loop
  3. updates final display to show each respective prompt and result.
  4. Tested with both PP=1 and PP=2
Screenshot 2024-09-15 at 12 48 00 PM

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1151

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5f71825 with merge base 8b45633 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 15, 2024
@lessw2020 lessw2020 requested a review from kwen2501 September 15, 2024 19:56
@kwen2501
Copy link
Contributor

kwen2501 commented Sep 15, 2024

If pp_degree = 1, the code as is would cause prompt_length to be incremented twice per iteration.

That's why in PR #1149 I consolidated the increments in one place.

Would be nice to test with --pp=1 flag.

@lessw2020 lessw2020 requested a review from kwen2501 September 15, 2024 23:00
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lessw2020 lessw2020 merged commit 03c9819 into main Sep 15, 2024
50 of 51 checks passed
@lessw2020 lessw2020 deleted the lessw2020/batch_decoding branch September 15, 2024 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants