Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Sep 18, 2024

Prefill phase and decoding phase are now done separately.
Decoding phase will leverage KV cache and speed improves.

Requires a PyTorch side fix to work. Will change the pin version.

Requires pytorch PR pytorch/pytorch#136243 to land.
Otherwise, you may hit issue described in: pytorch/pytorch#136225

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1162

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 3512101 with merge base e27e162 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 18, 2024
@kwen2501 kwen2501 requested a review from lessw2020 September 18, 2024 08:46

# create schedule
schedule = ScheduleGPipe(stage, mbs)
# TODO: figure out how to set input_pos for each prompt in the batch then we
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this limitation is probably our most important next step.

Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks great. Left comment but removing the all prompt same len is likely most important next step. Anyway this pr is a big step forward, nice job!

@kwen2501 kwen2501 changed the base branch from tp_not_sp to main September 20, 2024 06:35
@kwen2501 kwen2501 merged commit 8d01d9b into main Sep 20, 2024
49 of 51 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants