Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1171

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4831e83 with merge base 2cf4016 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 20, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: b4949c8
Pull Request resolved: #1171
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 20, 2024
@swolchok swolchok requested a review from Jack-Khuu September 20, 2024 22:21
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 23, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 8cb3a02
Pull Request resolved: #1171
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 23, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 0a2f418
Pull Request resolved: #1171
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 24, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: a132d7b
Pull Request resolved: #1171
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 24, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 2c002e3
Pull Request resolved: #1171
@swolchok swolchok merged commit 4831e83 into gh/swolchok/4/base Sep 24, 2024
51 checks passed
@swolchok
Copy link
Contributor Author

Ugh, some ghstack learning pains on my end here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants