This repository was archived by the owner on Sep 10, 2025. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 248
export.py: fix custom SDPA type conversion logic & re-enable for bfloat16 #1171
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
  This was referenced Sep 20, 2024 
      
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1171
 Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4831e83 with merge base 2cf4016 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
              
                    Jack-Khuu
  
              
              approved these changes
              
                  
                    Sep 21, 2024 
                  
              
              
            
            
              
                    byjlw
  
              
              approved these changes
              
                  
                    Sep 23, 2024 
                  
              
              
            
            
| Ugh, some ghstack learning pains on my end here. | 
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Stack from ghstack (oldest at bottom):
q.dtype is always torch.float at this point. Clearly meant to use the input dtype.