Add torchao #1182
Add torchao #1182
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1182
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ab3f26 with merge base e4b36f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
runner/et.cmake
Outdated
| endif() | ||
|
|
||
| if(LINK_TORCHAO_OPS) | ||
| target_link_libraries(et_run PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,${TORCHCHAT_ROOT}/torchao-build/cmake-out/lib/libtorchao_ops_executorch.a>") |
There was a problem hiding this comment.
For dynamic library test, change
target_link_libraries(et_run PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,${TORCHCHAT_ROOT}/torchao-build/cmake-out/lib/liblinear_a8wxdq_EXECUTORCH.a>")
to
target_link_libraries(et_run PRIVATE "${TORCHCHAT_ROOT}/torchao-build/cmake-out/lib/liblinear_a8wxdq_EXECUTORCH${CMAKE_SHARED_LIBRARY_SUFFIX}
and remove the following unnecessary libraries:
target_link_libraries(et_run PRIVATE
"${TORCHCHAT_ROOT}/torchao-build/cmake-out/lib/libtorchao_kernels_aarch64.a"
"${TORCHCHAT_ROOT}/torchao-build/cmake-out/lib/libtorchao_ops_linear_EXECUTORCH.a"
)
metascroy
force-pushed
the
add-torchao
branch
from
f51f5ad to
f8124e6
Compare
metascroy
force-pushed
the
add-torchao
branch
from
9ba889d to
088cc06
Compare
| python torchchat.py remove stories15m | ||
| test-mps: | ||
| uses: pytorch/test-infra/.github/workflows/macos_job.yml@main |
There was a problem hiding this comment.
This test is very flaky because it fails whenever a machine with python 3.9 is allocated. Change to always setup python 3.10.
There was a problem hiding this comment.
Thanks for fixing this test- it's been a thorn on our side for a while
| echo "Tests complete." | ||
| test-mps-dtype: | ||
| uses: pytorch/test-infra/.github/workflows/macos_job.yml@main |
There was a problem hiding this comment.
This test is very flaky because it fails whenever a machine with python 3.9 is allocated. Change to always setup python 3.10.
| find_cmake_prefix_path | ||
| clone_executorch | ||
| install_executorch_libs $ENABLE_ET_PYBIND | ||
| install_executorch_python_libs $ENABLE_ET_PYBIND |
There was a problem hiding this comment.
Move this to install_exeuctorch_python_libs because on the non-cache path in the CI, having it here doesn't work.
There was a problem hiding this comment.
If we remove this line: install_executorch_python_libs $ENABLE_ET_PYBIND
Where is this being called?
There was a problem hiding this comment.
It is called inside install_executorch_libs (which installs both c++ and python), so it was redundant
| python torchchat.py remove stories15m | ||
| test-mps: | ||
| uses: pytorch/test-infra/.github/workflows/macos_job.yml@main |
There was a problem hiding this comment.
Thanks for fixing this test- it's been a thorn on our side for a while
| python3 torchchat.py generate llama3 --pte-path llama3.pte --prompt "Hello my name is" | ||
| ``` | ||
|
|
||
| ## Experimental TorchAO lowbit kernels |
There was a problem hiding this comment.
I'll take pass at adding rich elements to this in a separate PR; Content looks good here
| find_cmake_prefix_path | ||
| clone_executorch | ||
| install_executorch_libs $ENABLE_ET_PYBIND | ||
| install_executorch_python_libs $ENABLE_ET_PYBIND |
There was a problem hiding this comment.
If we remove this line: install_executorch_python_libs $ENABLE_ET_PYBIND
Where is this being called?
|
Can you also update the title and description? |
* init * update install utils * update * update libs * update torchao pin * fix ci test * add python et install to ci * fix ci errors * fixes * fixes * fixes * fixes * fixes * fixes * fixes
No description provided.