This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Revert "Revert "export.py: fix custom SDPA type conversion logic & re-enable for bflo…" (#1197)" #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1199
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c8a35c with merge base f343b43 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 24, 2024
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Sep 24, 2024
|
confirming that I did actually look at the runner-et fp16 output on both jobs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies #1193 now that the native runner is fixed. We should
pay special attention to the runner-et job on this PR to make sure the
output is good.