This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Update Flamingo Builder to use Llama3ScaledRoPE instead of RotaryPositionalEmbeddings #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1202
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 078ac23 with merge base 021fd32 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
reviewed
Sep 25, 2024
torchchat/cli/builder.py
Outdated
|
|
||
| from torchchat.model import Model, ModelArgs, ModelType | ||
|
|
||
| from torchtune.modules.position_embeddings import RotaryPositionalEmbeddings |
There was a problem hiding this comment.
Let's get rid of the old one
Jack-Khuu
approved these changes
Sep 25, 2024
Jack-Khuu
reviewed
Sep 25, 2024
| for submodule in model.modules(): | ||
| if isinstance(submodule, RotaryPositionalEmbeddings): | ||
| if isinstance(submodule, Llama3ScaledRoPE): | ||
| submodule.__init__(head_dim, max_seq_len, rope_base) |
There was a problem hiding this comment.
nit: We should be populating the rest of the RoPE fields based on the config. This can be a separate PR
From tune:
scale_factor: int = 8,
low_freq_factor: int = 1,
high_freq_factor: int = 4,
old_context_len: int = 8192,
Jack-Khuu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a new rope class after bumped tune version.