Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Sep 25, 2024

Moved distributed folder into torchchat folder.

dist_run.py unfortunately have to stay at root a bit longer till either of the following happens:
(i) we support pip install of torchchat (needs a pyproject.toml) or
(ii) we refactor dist_run.py as a "main" backend callable by torchchat.py, like:

torchchat/torchchat.py

Lines 79 to 92 in 0b8ca05

elif args.command == "generate":
check_args(args, "generate")
from torchchat.generate import main as generate_main
generate_main(args)
elif args.command == "eval":
from torchchat.usages.eval import main as eval_main
eval_main(args)
elif args.command == "export":
check_args(args, "export")
from torchchat.export import main as export_main
export_main(args)

Item (ii) should be on our agenda.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1203

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6a5fb19 with merge base 0b8ca05 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 25, 2024
#export CUDA_VISIBLE_DEVICES=4,5,6,7
PORT=${1:-29501}
NGPU=${NGPU:-"4"}
LOG_RANK=${LOG_RANK:-0,1,2,3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch...lol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave this file in for now.

Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
I would still like to keep the run_dist.sh as I use it a lot.
Thanks for moving us into the right long term location.

@kwen2501 kwen2501 merged commit 6b3238c into main Sep 25, 2024
51 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants