This repository was archived by the owner on Sep 10, 2025. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 248
Update torchtune pin to Llama 3.2 Release #1205
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1205
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit 0551988 with merge base f7aef8a ( NEW FAILURES - The following jobs have failed:
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
              
                    byjlw
  
              
              approved these changes
              
                  
                    Sep 25, 2024 
                  
              
              
            
            
              
                    Gasoonjia
  
              
              approved these changes
              
                  
                    Sep 25, 2024 
                  
              
              
            
            
              
                    Gasoonjia
  
              
              reviewed
              
                  
                    Sep 25, 2024 
                  
              
              
            
            
| from PIL import Image | ||
| from torchtune.data import Message | ||
|  | ||
| from torchtune.data import Message, padded_collate | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to double check about padded_collate func here;  in the generation.py we've replaced it with padded_collate_tiled_images_and_mask
| This solves a good chunk of the issues with CI and enablement. Landing first and will iterate onthe remaining errors | 
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Solves a large chunk of the CI errors, but bumping the torchtune pin.
There is still an Eval bug that will be investigated in a following PR