Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Jack-Khuu
Copy link
Contributor

@Jack-Khuu Jack-Khuu commented Sep 25, 2024

Solves a large chunk of the CI errors, but bumping the torchtune pin.

There is still an Eval bug that will be investigated in a following PR

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1205

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 0551988 with merge base f7aef8a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 25, 2024
from PIL import Image
from torchtune.data import Message

from torchtune.data import Message, padded_collate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to double check about padded_collate func here; in the generation.py we've replaced it with padded_collate_tiled_images_and_mask

@Jack-Khuu
Copy link
Contributor Author

This solves a good chunk of the issues with CI and enablement.

Landing first and will iterate onthe remaining errors

@Jack-Khuu Jack-Khuu merged commit 6ae4211 into main Sep 25, 2024
42 of 51 checks passed
@Jack-Khuu Jack-Khuu deleted the tune-ci branch January 24, 2025 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants