This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add check for rocminfo in the installation script to replace the nightly URL with the appropriate ROCm whl. #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly URL with the appropriate ROCm whl.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1279
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e06e0f with merge base 2739023 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
jeffdaily
reviewed
Oct 7, 2024
use nightly Co-authored-by: Jeff Daily <[email protected]>
Jack-Khuu
approved these changes
Oct 7, 2024
houseroad
approved these changes
Oct 7, 2024
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Looks good.
Wondering @xw285cornell would like to have a double check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ROCm systems, running this script will not set up PyTorch with ROCm compatibility. This change should make users' experience smoother on AMD GPU systems. Will test on an AMD GPU system & update PR